Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsinsider: Match the usage of nsinsider to the current codebase. #8275

Merged
merged 1 commit into from
Feb 17, 2022
Merged

nsinsider: Match the usage of nsinsider to the current codebase. #8275

merged 1 commit into from
Feb 17, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Feb 17, 2022

Description

Update the usage. Previously, 3 was used for hard coding.

gitpod/components/ws-daemon/nsinsider/main.go

Line 31 in 2b4ae94

return syscallMoveMount(3, "", unix.AT_FDCWD, c.String("target"), flagMoveMountFEmptyPath)

Related Issue(s)

None

How to test

None

Release Notes

Update the usage of nsinsider.

Documentation

No

@utam0k utam0k requested a review from a team February 17, 2022 12:41
@github-actions github-actions bot added team: workspace Issue belongs to the Workspace team and removed size/XS labels Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #8275 (3a4984f) into main (5f6114c) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8275      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-installation-telemetry-app ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-daemon-nsinsider-app ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6114c...3a4984f. Read the comment docs.

@roboquat roboquat merged commit 572bade into main Feb 17, 2022
@roboquat roboquat deleted the to/update-nsinsider-usage branch February 17, 2022 13:53
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utam0k @csweichel @roboquat